feat: outgoing traceparent header support
#1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaMoelans
commented
Sep 30, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@sentry review |
supervacuus
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Thanks, that looks great; only minor things.
What I currently miss is a user-facing explanation of the hierarchy between sentry-trace and traceparent on the incoming side (which is unaffected by propagate_traceparent). That's totally fine if it's evident in the accompanying docs.
Also, does this currently test an outgoing traceparent coexisting with a sentry-trace (they are not mutually exclusive when outgoing, right)?
| bool attach_screenshot; | ||
| bool crashpad_wait_for_upload; | ||
| bool enable_logging_when_crashed; | ||
| bool propagate_traceparent; |
There was a problem hiding this comment.
One of these days, we should convert all these flags to bitfields. But not in this PR.
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
* cleanup * remove feature of parsing incoming traceparent * re-add len macros
…for transactions and spans
supervacuus
approved these changes
Oct 8, 2025
JoshuaMoelans
changed the title
traceparent header supporttraceparent header support
|
6 tasks
JoshuaMoelans
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 9, 2025
Vercel previews: - [options](https://sentry-docs-git-joshua-featpropagatetraceparentoption.sentry.dev/platforms/native/configuration/options/#propagate-traceparent) - [trace propagation example](https://sentry-docs-git-joshua-featpropagatetraceparentoption.sentry.dev/platforms/native/tracing/trace-propagation/custom-instrumentation/) ## DESCRIBE YOUR PR Documents the changes from getsentry/sentry-native#1394 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1350
For now, this is only propagated on outgoing requests. The handling of incoming requests was initially added too (see commit range), but this is not required (yet) by our spec.
Related docs PR getsentry/sentry-docs#15162
Develop Docs:
propagatetraceparent
w3c-trace-context-header